render+web: latex pipeline fixes, error visibility, render UX #28
Loading…
Reference in a new issue
No description provided.
Delete branch "integrator/render-and-editor-ux"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
User-reported round (6 items)
validateFamirrored the pre-ε contract (symbols ⊆ alphabet), so every Thompson NFA was structurally invalid client-side. ε is now legal outside the alphabet, matching the amended backend. Regression-tested.>=latex'arrow tips removed in modern pgf,ellipseshape needingshapes.geometric. Pipeline verified in-container and live.[ SAVE SVG ]button (blob download, name derived from the saved doc).application/jsonon non-GET/HEAD. Root cause + fix verified against the live stack (403 → 204).Error visibility (the meta-issue)
crates/rgxr-api/src/error.rs:RenderError::Faileddetail now lands in the envelope message ("render failed: pdflatex exited with code 1: ! LaTeX Error: …") instead of only the tracing log. Tool output, not internals; 2 lines. Flagging for your review — revert to log-only if you object and I will open an issue instead.Gates
cargo fmt+clippy --workspace --all-targetsclean; 99 tests green (44 core + 28 core-acceptance + 11 api + 16 render; new: ε math label, pgf3 compat, snippet tail/capture).bun test13 pass (new client + fa suites);svelte-check0 errors; build green.(a|b)*abthrough the proxy — previously failed at save AND render, now green.Six user-reported issues, one round: Latex render (crates/rgxr-render): - ε edges emitted the raw U+03B5 glyph, which pdflatex's inputenc rejects ("Unicode character ε not set up") — every Thompson construction failed with a swallowed error. The latex dot now carries a math-mode $\varepsilon$ label (pipeline-generated; user names stay verbatim-escaped, no TeX-injection path). - dot2tex emits pgf-2.x arrow tips (>=latex') that modern pgf removed, and ellipse node shapes that live in shapes.geometric — rewritten/ loaded (pgf3_compat + standalone_doc preamble). - error visibility: the failure snippet read stderr only, but pdflatex reports on stdout — snippets now carry the combined tail of both streams, and the api envelope includes the detail instead of a bare "render failed" (crates/rgxr-api/src/error.rs — CROSS-LANE per #20: 2-line change, flagged for review). Web (web/): - validateFa mirrored the pre-ε contract: any Thompson NFA was "structurally invalid" client-side, blocking save-after-transform. ε is now legal outside the alphabet, matching the backend. - bodyless DELETEs went out without a content-type and were killed by SvelteKit's CSRF check (missing content-type counts as form content, even same-origin) → the delete button's 403. Non-GET/HEAD requests now always carry application/json. - render modal: zoom (50-400%, fit reset), scroll panning, paper card for latex output (black-on-transparent paths read on white), wide variant, and a [ SAVE SVG ] download button. Gates: 99 rust tests green (incl. new ε-label, pgf3-compat, snippet tests); 13 web tests (new client + fa suites); svelte-check clean; build green; live stack verification: regex→nfa→save→latex render of (a|b)*ab works through the proxy (previously failed at save and render).